[PATCH 3/6] ARM: tegra: update GPIO chained IRQ handler to use EOI in parent chip
From: Sergei Shtylyov <hidden>
Date: 2011-03-01 13:11:40
Hello. On 28-02-2011 16:33, Will Deacon wrote:
The chained GPIO IRQ handler on Tegra calls ->irq_ack on the parent chip prior to handling the interrupt.
This patch updates the code to use ->irq_eoi now that the GIC has moved to using the fasteoi flow model.
quoted hunk ↗ jump to hunk
Acked-by: Colin Cross<redacted> Signed-off-by: Will Deacon<redacted> --- arch/arm/mach-tegra/gpio.c | 17 +---------------- 1 files changed, 1 insertions(+), 16 deletions(-)diff --git a/arch/arm/mach-tegra/gpio.c b/arch/arm/mach-tegra/gpio.c index ad80488..5019b01 100644 --- a/arch/arm/mach-tegra/gpio.c +++ b/arch/arm/mach-tegra/gpio.c@@ -219,9 +219,6 @@ static void tegra_gpio_irq_handler(unsigned int irq, struct irq_desc *desc) struct tegra_gpio_bank *bank; int port; int pin; - int unmasked = 0; - - desc->irq_data.chip->irq_ack(&desc->irq_data);
Won't this code break after the first patch as it removes irq_ack()
method? I.e. shouldn't the patches be combined to keep them bisectable?
WBR, Sergei