On Wednesday 09 March 2011 17:59:20 Maxime Coquelin wrote:

Common base to export System-on-Chip related informations through sysfs.

Creation of a "soc" directory under /sys/devices/system/.

Why under system?

As far as I can tell, the SOC already exists as a platform device
under /sys/devices/platform, so just put the data in there.

There is no point in having the same physical device represented
as multiple separate instances in sysfs.

Creation of a common "mach_name" entry to export machine name.
Creation of platform-defined SoC information entries.

Signed-off-by: Maxime COQUELIN <redacted>
---
 drivers/base/Kconfig    |    4 ++
 drivers/base/Makefile   |    1 +
 drivers/base/soc.c      |   88 +++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/sys_soc.h |   33 +++++++++++++++++

This seems to be missing the documentation file. Every sysfs
attribute you create must be documented.

CONFIG_EMBEDDED is gone, and did not mean what you intended.

Just make the information unconditionally available in
the code that manages you SoC. 

+void __init register_sys_soc(char *name, struct sys_soc_info *info, int num)
+{
+	int len;
+
+	len = strlen(name);
+	soc.mach_name = kzalloc(len + 1, GFP_KERNEL);
+	if (!soc.mach_name)
+		return;
+
+	sprintf(soc.mach_name, "%s", name);
+
+	if (sysdev_class_register(&soc.class)) {
+		kfree(soc.mach_name);
+		return;
+	}
+
+	register_sys_soc_info(info, num);
+}

You do way too much here when all you need is a platform
device attribute.

	Arnd