[PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI

Hi Fabio,

-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: Friday, March 18, 2011 10:31 AM
To: Nguyen Dinh-R00091
Cc: linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
linux at arm.linux.org.uk; s.hauer at pengutronix.de; u.kleine-
koenig at pengutronix.de; arnaud.patard at rtp-net.org; Vaidyanathan Ranjani-
RA5478; Zhang Lily-R58066
Subject: Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to
enter WFI

Hi Dinh,

On Fri, Mar 18, 2011 at 12:21 PM,  [off-list ref] wrote:
...

quoted

+ ? ? ? /* Enable NEON SRPG for all but MX50TO1.0. */
+ ? ? ? if (cpu_is_mx51() || cpu_is_mx53())
+ ? ? ? ? ? ? ? __raw_writel(arm_srpgcr, MXC_SRPG_NEON_SRPGCR);

The comment says that NEON SRPG should not be enabled for MX50 TO1.0,
but your code does not check the MX50 silicon revision.

There is no mechanism for checking MX50 Revisions yet. I'll work on adding the MX50 revision check.

Dinh

Regards,

Fabio Estevam