[PATCH 2/3] msm: Peripheral Image Loader (PIL) driver
From: Daniel Walker <hidden>
Date: 2011-03-16 10:20:49
Also in:
linux-arm-msm, lkml
On Wed, 2011-03-09 at 20:44 -0800, Stephen Boyd wrote:
On 8660, the modem, dsp, and sensors peripherals require their firmware to be loaded into memory before they can be properly taken out of reset. Drivers are expected to call pil_get() when they wish to load a peripheral. This will initiate multiple firmware_request()s for the metadata and image blobs for a peripheral. Once the image has been loaded into memory, it is validated and brought out of reset via the peripheral reset driver.
Why can't this be part of the generic firmware request API ?
Change-Id: I041139464bbd3b646b82370ab540f40b0ac9af6b
Can't have Change-Id's ..
quoted hunk ↗ jump to hunk
Reviewed-by: Saravana Kannan <redacted> Signed-off-by: Stephen Boyd <redacted> --- arch/arm/mach-msm/Kconfig | 13 + arch/arm/mach-msm/Makefile | 2 + arch/arm/mach-msm/include/mach/peripheral-loader.h | 23 + arch/arm/mach-msm/peripheral-loader.c | 402 +++++++++++++++ arch/arm/mach-msm/peripheral-loader.h | 38 ++ arch/arm/mach-msm/peripheral-reset.c | 528 ++++++++++++++++++++ 6 files changed, 1006 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-msm/include/mach/peripheral-loader.h create mode 100644 arch/arm/mach-msm/peripheral-loader.c create mode 100644 arch/arm/mach-msm/peripheral-loader.h create mode 100644 arch/arm/mach-msm/peripheral-reset.cdiff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig index 997c5bd..25b73b0 100644 --- a/arch/arm/mach-msm/Kconfig +++ b/arch/arm/mach-msm/Kconfig@@ -210,4 +210,17 @@ config IOMMU_API config MSM_SCM bool + +config MSM_PIL + bool "Peripheral image loading (PIL)" + select FW_LOADER + select MSM_SCM + depends on ARCH_MSM8X60 + help + Some peripherals need to be loaded into memory before theycan be + brought out of reset. + + Say yes to support these devices. + +
You shouldn't be adding anything like this to the Kconfig. To me if you add stuff like this it's a big red flag. I didn't review the rest sign it might be wasted effort on my part.. Daniel