[PATCH v8 1/1] PRUSS UIO driver support
From: arnd@arndb.de (Arnd Bergmann)
Date: 2011-03-02 20:24:31
Also in:
lkml
From: arnd@arndb.de (Arnd Bergmann)
Date: 2011-03-02 20:24:31
Also in:
lkml
On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote:
quoted
+static struct uio_info *info; +static dma_addr_t sram_paddr, ddr_paddr; +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;So the correct thing would be static void __iomem *prussio_vaddr; static void *sram_vaddr, *ddr_vaddr;
I also commented that it should not be a global variable at all, but a dynamic data structure referenced from the device. Not important, but Pratheesh said he'd change it. If it stays a global variable, I'd at least expect an explanation why the static variable is considered better in this case. Arnd