[PATCH 2/4] msm: scm: Fix improper register assignment
From: nico@fluxnic.net (Nicolas Pitre)
Date: 2011-03-02 00:02:30
Also in:
linux-arm-msm, lkml
From: nico@fluxnic.net (Nicolas Pitre)
Date: 2011-03-02 00:02:30
Also in:
linux-arm-msm, lkml
On Tue, 1 Mar 2011, Saravana Kannan wrote:
On 03/01/2011 02:37 AM, Will Deacon wrote:quoted
Perhaps a more robust fix would be to remove the register int declarations and handle the parameter marshalling in the same asm block that contains the smc?I was thinking the same, but the opposing idea I heard was that not doing it inside the asm block would allow GCC to be make better use of the registers.
Indeed. And a significant body of code out there does rely on this gcc feature, so it has to minimally work.
Didn't have a strong opinion either way, so we went with the implementation that was sent out.
ACK. Nicolas