Thread (11 messages) flat view 11 messages, 6 authors, 2011-02-22

[linux-pm] [PATCH] amba: move to pm ops

From: Rabin Vincent <hidden>
Date: 2011-02-21 07:36:59

On Thu, Feb 17, 2011 at 23:14, Takashi Iwai [off-list ref] wrote:
At Thu, 17 Feb 2011 13:19:46 +0530,
Rabin Vincent wrote:
quoted
Support pm_ops in the AMBA bus instead of the legacy ops. ? pm_ops is needed
for runtime pm, and there is also a general move to convert drivers to
dev_pm_ops rather than bus specific PM ops in order to facilitate core
development.

Since there are only 6 AMBA drivers using suspend/resume, convert them all in
one go and directly use the GENERIC_SUBSYS_PM_OPS in the bus.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Chris Ball <redacted>
Cc: Grant Likely <redacted>
Cc: Takashi Iwai <redacted>
Cc: Linus Walleij <redacted>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Rabin Vincent <redacted>
For sound/arm/aaci.c,

?Acked-by: Takashi Iwai [off-list ref]

Though, this would result in a zero-filled *_pm struct when
CONFIG_PM_* isn't set? ?It's a few bytes wastes ;)
Thank you for the ack.  However, in v2 of the patch I've done a
different implementation in the bus code that doesn't necessitate
the conversion of all the drivers together, so this part is
dropped.  I will take this comment into consideration if I do
end up converting all the drivers.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help