Thread (4 messages) flat view 4 messages, 3 authors, 2011-02-21
STALE5654d

[PATCH v2] mxcmmc: use dmaengine API

From: Chris Ball <hidden>
Date: 2011-02-20 19:31:36
Also in: linux-mmc

Hi Sascha,

On Fri, Feb 18, 2011 at 02:37:02PM +0100, Arnd Bergmann wrote:
On Friday 18 February 2011, Sascha Hauer wrote:
quoted
This switches the mxcmmc driver to use the dmaengine API. Unlike
the old one this one is always present in the tree, even if no DMA
is implemented, hence we can remove all the #ifdefs in from the driver.
The driver automatically switches to PIO mode if no DMA support or no
suitable channel is available.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
The patch looks good to me, but shouldn't you also add a Kconfig
dependency or select on CONFIG_DMA_ENGINE? I don't see where that
gets set.

Acked-by: Arnd Bergmann <arnd@arndb.de>
I've pushed this to mmc-next now, but please do reply to Arnd's Kconfig
question.

Thanks,

-- 
Chris Ball   [off-list ref]   <http://printf.net/>
One Laptop Per Child
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help