Thread (4 messages) read the whole thread 4 messages, 2 authors, 2011-02-20

barriers in mutexes?

From: Russell King - ARM Linux <hidden>
Date: 2011-02-20 13:14:02

On Thu, Feb 03, 2011 at 08:56:15AM -0800, Steve Muckle wrote:
On 02/03/11 03:08, Russell King - ARM Linux wrote:
quoted
On Wed, Feb 02, 2011 at 06:05:46PM -0800, Steve Muckle wrote:
quoted
Looking at kernel/mutex.c and arch/arm/include/asm/mutex.h, it appears
there aren't any memory barriers in the fast path of mutexes. I see this
was discussed here a long time back:

http://patchwork.kernel.org/patch/25856/

How was this resolved?
bac4e96 ([ARM] barriers: improve xchg, bitops and atomic SMP barriers)
The fast path of mutexes on ARM >= v6 doesn't seem to use these
operations - it's just ldrex/strex. Looking at the v7 ARM ARM it seems
barriers are still required with ldrex/strex.
Patch welcome.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help