Thread (15 messages) flat view 15 messages, 5 authors, 2011-02-18
STALE5658d

Revision v5 of 6 in this series.

Revisions (6)
  1. v3 [diff vs current]
  2. v4 [diff vs current]
  3. v5 [diff vs current]
  4. v5 [diff vs current]
  5. v5 current
  6. v5 [diff vs current]

[PATCH v5 3/5] OMAP4: hwmod data: add mailbox data

From: Ramirez Luna, Omar <hidden>
Date: 2011-02-15 21:55:41
Also in: linux-omap

Hi Benoit,

On Mon, Feb 14, 2011 at 9:00 AM, Cousson, Benoit [off-list ref] wrote:
quoted
+static struct omap_hwmod_irq_info omap44xx_mailbox_irqs[] = {
+ ? ? ? { .name = "mbox", .irq = 26 + OMAP44XX_IRQ_GIC_START, },
The original entry was unnamed since it is an unique entry and thus does not
need to be differentiate on this platform.

? ? ? ?{ .irq = 26 + OMAP44XX_IRQ_GIC_START },

Do you really need to have a name here? The strategy being to provide a name
only if more than one entry exist.
It is perfectibility doable, I'm just trying to understand your rational.
It is this way instead of plain platform_get_irq because omap2420 has
two interrupt sources to MPU and mailbox driver uses
platform_get_irq_byname to get the irq number.

Regards,

Omar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help