[PATCH v2] ARM: S5PV210: Add GONI board setup for CIF camera support
From: Kukjin Kim <hidden>
Date: 2011-02-15 10:26:52
Also in:
linux-samsung-soc
Sylwester Nawrocki wrote:
Hi Kukjin,
Hi :)
quoted
Hmm...looks you don't want to follow my suggestion on 2nd patch.I've attempted to make a change as you suggested but it turned out that all regulators I'm adding supplies for in the second patch are also used by the other, high resolution camera. It's not about I don't want to follow you suggestions. The argument is that I's like to add
shortly
support for the other camera and then the patch would be just one line per a power supply rather than 4. I really don't mind to adhere to your preferred style. But in this case it would be just more work to revert things back and forth.
Ok, I see, no problem.
I've boot tested your patch: ARM: S5PV210: Use REGULATOR_SUPPLY macro for regulator consumers on Aquila and GONI board altogether with my changeset.
Thanks :)
quoted
I'm still wondering why array is needed for just one member in regulator_consumer_supply structure now even though other something will
be
quoted
added later. Nevertheless will apply your 3 patches but if not required array will be removed later.Thanks! I am going to post further patches for this board soon so there should be no need to change anything. Please use you time for more
important
things ;)
Hehehe, ok and don't worry ;)
I've noticed one issue with the first patch, i.e. Kyungmin's email address is broken. Should I resend the patch or could you please correct this on
your
side?
Oops, ok. I fixed it. As a note, I received request about common phy control from Marek. So I will re-think with your mini phy patches, then let you know about that soon. Thanks. Best regards, Kgene. -- Kukjin Kim [off-list ref], Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.