[PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

On Thu, Feb 10, 2011 at 9:38 PM, Kevin Hilman [off-list ref] wrote:

Santosh Shilimkar [off-list ref] writes:

[...]

quoted

quoted

The SD card gets suspended, but nothing else seems to happen, and I
can't resume the system.

Am I doing something wrong?

MMC suspend is broken. I use ramdisk-ext3 or NFS for my testing

Just to clarify, MMC suspend is not broken. ?It's a "feature" the MMC
core. ?See the help text of the following Kconfig option, and ensure
that it's enabled:


config MMC_UNSAFE_RESUME
? ? ? ?bool "Assume MMC/SD cards are non-removable (DANGEROUS)"
? ? ? ?help
? ? ? ? ?If you say Y here, the MMC layer will assume that all cards
? ? ? ? ?stayed in their respective slots during the suspend. The
? ? ? ? ?normal behaviour is to remove them at suspend and
? ? ? ? ?redetecting them at resume. Breaking this assumption will
? ? ? ? ?in most cases result in data corruption.

? ? ? ? ?This option is usually just for embedded systems which use
? ? ? ? ?a MMC/SD card for rootfs. Most people should say N here.

? ? ? ? ?This option sets a default which can be overridden by the
? ? ? ? ?module parameter "removable=0" or "removable=1".

Looking at Dave's .config, this option is disabled, so suspend will hang
when rootfs is on MMC.

Thanks for the clarification.  For simplicity, and since Thumb-2
should be unrelated to the MMC subsystem, I've been testing suspend
from the initramfs instead ... which sidesteps the MMC issue.

Power-off-suspend does still have some weird problems when
CONFIG_THUMB2_KERNEL is enabled; I'm still investigating this.

Cheers
---Dave