[PATCH v3 2/5] ARM: pm: add generic CPU suspend/resume support
From: saeed bishara <hidden>
Date: 2011-02-07 14:04:09
It's really not nice to page down and down and down to find out the one or two lines that actually contain something useful - or in my case scroll through the first three pages, then go to the bottom and start scrolling up. ?It wastes time.
sorry
quoted
this code doesn't look smp save, it modifies page table that could be used by another cpu. I suggest to create (at ?boot time) identity page table and use it in order to do mmu on.When you suspend/resume, the other CPUs will be hot-unplugged before suspend, and hot-plugged after resume. ?SMP issues really don't come in here, and there's not really many other ways to solve the inherent races involved with turning on the MMU.
that's right, but in the future this code can be used also for cpuidle, so please take that into account. also, I think cpu_resume_after_mmu needs to invalidates the TLB after restoring the old mapping. one more comment, don't you need to restore the context ID cp15 register? saeed