[PATCH 2/4] ARM: Xilinx: Adding Xilinx board support

-----Original Message-----
From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
Sent: Saturday, February 05, 2011 9:19 AM
To: John Linn
Cc: linux-arm-kernel at lists.infradead.org; kernel at vger.kernel.org;

catalin.marinas at arm.com;

glikely at secretlab.ca
Subject: Re: [PATCH 2/4] ARM: Xilinx: Adding Xilinx board support

On Sat, Feb 05, 2011 at 09:08:42AM -0700, John Linn wrote:

quoted

+void __init irq_init(void)
+{
+	gic_cpu_base_addr = (void __iomem *)SCU_GIC_CPU_BASE;

Just pass this address into gic_init - there's no need to initialize
this variable yourself anymore.

quoted

+	gic_init(0, 29, (void __iomem *)SCU_GIC_DIST_BASE,

gic_cpu_base_addr);

...

quoted

+static struct map_desc io_desc[] __initdata = {

...

quoted

+#ifdef CONFIG_DEBUG_LL
+	{
+		.virtual	= UART0_BASE,
+		.pfn		= __phys_to_pfn(UART0_BASE),
+		.length		= SZ_4K,
+		.type		= MT_DEVICE,
+	},
+#endif

You shouldn't need to do this if your addruart macro in

mach/debug-macros.S

is correctly returning the virtual and physical addresses in rp and

rv.

I'm sure there's something I'm overlooking here.

I'm seeing that when I remove that I get I/O just for a bit, then it
stops. I think
that means my addruart macro is working correctly.
 
I know the UART gets an early mapping in the MMU in head.S.  But does
that mapping
stay when the map_io function is ran?  

Thanks,
John

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.