[alsa-devel] [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards
From: Mika Westerberg <hidden>
Date: 2011-02-02 07:54:34
Also in:
alsa-devel
On Wed, Feb 02, 2011 at 02:40:53AM +0300, Alexander Sverdlin wrote:
From: Alexander Sverdlin <redacted> Add support for CS4271 SPI-connected CODEC on EDB93xx boards. Major rework based on code provided by H Hartley Sweeten [off-list ref]. Tested on EDB9302, others (EDB9301, EDB9302A, EDB9307A, EDB0315A) should work.
One minor comment, see below.
quoted hunk ↗ jump to hunk
Signed-off-by: Alexander Sverdlin <redacted> --- arch/arm/mach-ep93xx/edb93xx.c | 117 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 117 insertions(+), 0 deletions(-)diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 4b04316..f20be96 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c@@ -30,12 +30,22 @@ #include <linux/gpio.h> #include <linux/i2c.h> #include <linux/i2c-gpio.h> +#include <linux/spi/spi.h> +#include <linux/delay.h> +#include <mach/ep93xx_spi.h> #include <mach/hardware.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> +#include <sound/cs4271.h> + +#define edb93xx_has_audio() (machine_is_edb9301() || \ + machine_is_edb9302() || \ + machine_is_edb9302a() || \ + machine_is_edb9307a() || \ + machine_is_edb9315a()) static void __init edb93xx_register_flash(void) {@@ -93,6 +103,111 @@ static void __init edb93xx_register_i2c(void) /************************************************************************* + * EDB93xx SPI peripheral handling + *************************************************************************/ +static int edb93xx_cs4271_hw_setup(struct spi_device *spi) +{ + int gpio_nreset; + int err; + + if (machine_is_edb9301() || machine_is_edb9302()) { + gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; + } else if (machine_is_edb9302a() || machine_is_edb9307a()) { + ep93xx_devcfg_set_bits(EP93XX_SYSCON_DEVCFG_HONIDE); + gpio_nreset = EP93XX_GPIO_LINE_DD2; + } else if (machine_is_edb9315a()) { + gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; + } else { + return -EINVAL; + } + + err = gpio_request(gpio_nreset, spi->modalias); + if (err) + return err; + err = gpio_request(EP93XX_GPIO_LINE_EGPIO6, spi->modalias); + if (err)
Should you call gpio_free() for gpio_nreset here? Regards, MW
+ return err; + + gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 1); + + /* Reset codec */ + gpio_direction_output(gpio_nreset, 0); + udelay(1); + gpio_set_value(gpio_nreset, 1); + /* Give the codec time to wake up */ + udelay(1); + + return 0; +}