On Thu, 24 Feb 2011, Stephen Boyd wrote:

On 02/24/2011 11:01 AM, Thomas Gleixner wrote:

quoted

On Thu, 24 Feb 2011, Stephen Boyd wrote:

quoted

 /**
  * scm_call() - Send an SCM command
  * @svc_id: service identifier

@@ -243,11 +248,13 @@ int scm_call(u32 svc_id, u32 cmd_id, const void *cmd_buf, size_t cmd_len,
 	do {
 		u32 start = (u32)rsp;
 		u32 end = (u32)scm_get_response_buffer(rsp) + resp_len;
-		start &= ~(CACHELINESIZE - 1);
+		u32 cacheline_size = dcache_line_size();

And why do you want to do that on every scm_call() invocation and on
every loop of that code? If your dcache_line_size() changes at
runtime, then you might have other problems.

I definitely don't want to do it for every loop. I'm fine with getting
it every scm_call() invocation though.

For now, I'll pull the end and cacheline_size variables out of the
do-while loop.

Why not do it correct right away and retrieve it in an __init
function?

Thanks,

	tglx