On Fri, Feb 18, 2011 at 10:46 AM, Daniel Walker [off-list ref] wrote:

On Thu, 2011-02-17 at 16:51 -0800, Bryan Huntsman wrote:

quoted

On 02/17/2011 04:37 PM, Daniel Walker wrote:

quoted

Can you put this in drivers/ this doesn't looks like it need to be here.

Where would you suggest? ?The initial attempt to model SSBI as an I2C
bus didn't go anywhere. ?See http://lkml.org/lkml/2010/7/21/400. ?This
functionality is specific to MSM. ?Plus, we're trying to maintain
similarity to the Android MSM tree. ?That may not matter to people who
don't use MSM, but is matters to us. ?Given these considerations, the
current location seems as good a place as any.

I don't know the driver well enough to be more detailed than suggesting
drivers/ . In the thread you quoted Pavel (who I added to the CC line)
suggested drivers/ssbi/ .

I'm not sure that knowing the driver would help. SSBI is a Qualcomm
proprietary protocol that will only ever have one ssbi "host" driver
in it. The slave is always the PMIC (maybe the audio codec too, but
that's normally speaking i2c even in qualcomm's case). The slave PMIC
drivers, however, will go under drivers/mfd for the core and the
peripheral drivers into the appropriate drivers/xxx/ dirs, just like
all the other pmic drivers. The audio codec would go into
sound/soc/codecs. Thus, adding drivers/ssbi/ to just house ssbi.c
doesn't really make sense to me.

What is the problem leaving it under arch/arm/mach-msm?

--Dima