[PATCH v2 15/21] ARM: tegra: clock: Round rate before setting rate

[PATCH v2 12/21] ARM: tegra: clock: Add shared bus clock type · Colin Cross <hidden> · 2011-02-19
[PATCH v2 00/21] Tegra clock updates for 2.6.39 · Colin Cross <hidden> · 2011-02-19
[PATCH v2 05/21] ARM: tegra: clock: Disable clocks left on by bootloader · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 05/21] ARM: tegra: clock: Disable clocks left on by bootloader · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 05/21] ARM: tegra: clock: Disable clocks left on by bootloader · Colin Cross <hidden> · 2011-02-21
Re: [PATCH v2 05/21] ARM: tegra: clock: Disable clocks left on by bootloader · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 13/21] ARM: tegra: clock: Remove unnecessary uses of #ifdef CONFIG_DEBUG_FS · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 13/21] ARM: tegra: clock: Remove unnecessary uses of #ifdef CONFIG_DEBUG_FS · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 06/21] ARM: tegra: clock: Initialize clocks that have no enable · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 06/21] ARM: tegra: clock: Initialize clocks that have no enable · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 15/21] ARM: tegra: clock: Round rate before setting rate · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 15/21] ARM: tegra: clock: Round rate before setting rate · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 15/21] ARM: tegra: clock: Round rate before setting rate · Colin Cross <hidden> · 2011-02-21
[PATCH v2 08/21] ARM: tegra: clock: Rearrange static clock tables · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 08/21] ARM: tegra: clock: Rearrange static clock tables · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 16/21] ARM: tegra: Add external memory controller driver · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 16/21] ARM: tegra: Add external memory controller driver · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 11/21] ARM: tegra: cpufreq: Take an extra reference to pllx · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 11/21] ARM: tegra: cpufreq: Take an extra reference to pllx · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 14/21] ARM: tegra: clock: Refcount periph clock enables · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 14/21] ARM: tegra: clock: Refcount periph clock enables · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 14/21] ARM: tegra: clock: Refcount periph clock enables · Colin Cross <hidden> · 2011-02-21
[PATCH v2 12/21] ARM: tegra: clock: Add shared bus clock type · Colin Cross <hidden> · 2011-02-19
[PATCH v2 09/21] ARM: tegra: clock: Move unshared clk struct members into union · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 09/21] ARM: tegra: clock: Move unshared clk struct members into union · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 09/21] ARM: tegra: clock: Move unshared clk struct members into union · Colin Cross <hidden> · 2011-02-21
[PATCH v2 10/21] ARM: tegra: clock: Convert global lock to a lock per clock · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 10/21] ARM: tegra: clock: Convert global lock to a lock per clock · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 01/21] ARM: tegra: clock: enable clk reset for non-peripheral clocks · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 01/21] ARM: tegra: clock: enable clk reset for non-peripheral clocks · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 03/21] ARM: tegra: clock: Drop debugging · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 03/21] ARM: tegra: clock: Drop debugging · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 03/21] ARM: tegra: clock: Drop debugging · Colin Cross <hidden> · 2011-02-21
[PATCH v2 04/21] ARM: tegra: clock: Don't use PLL lock bits · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 04/21] ARM: tegra: clock: Don't use PLL lock bits · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 02/21] ARM: tegra: clock: Don't BUG on changing an enabled PLL · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 02/21] ARM: tegra: clock: Don't BUG on changing an enabled PLL · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 02/21] ARM: tegra: clock: Don't BUG on changing an enabled PLL · Colin Cross <hidden> · 2011-02-21
[PATCH v2 21/21] ARM: tegra: clock: Miscellaneous clock updates · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 21/21] ARM: tegra: clock: Miscellaneous clock updates · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 19/21] ARM: tegra: clock: Add function to set SDMMC tap delay · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 19/21] ARM: tegra: clock: Add function to set SDMMC tap delay · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 18/21] ARM: tegra: cpufreq: Adjust memory frequency with cpu frequency · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 18/21] ARM: tegra: cpufreq: Adjust memory frequency with cpu frequency · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 17/21] ARM: tegra: clocks: Add emc scaling · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 17/21] ARM: tegra: clocks: Add emc scaling · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 20/21] ARM: tegra: clock: Fix clock issues in suspend · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 20/21] ARM: tegra: clock: Fix clock issues in suspend · Olof Johansson <hidden> · 2011-02-21
[PATCH v2 07/21] ARM: tegra: clock: Drop CPU dvfs · Colin Cross <hidden> · 2011-02-19
Re: [PATCH v2 07/21] ARM: tegra: clock: Drop CPU dvfs · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 12/21] ARM: tegra: clock: Add shared bus clock type · Olof Johansson <hidden> · 2011-02-21
Re: [PATCH v2 12/21] ARM: tegra: clock: Add shared bus clock type · Colin Cross <hidden> · 2011-02-21

From: Olof Johansson <hidden>
Date: 2011-02-21 04:19:55
Also in: linux-tegra, lkml

Hi,

On Sat, Feb 19, 2011 at 2:26 PM, Colin Cross [off-list ref] wrote:

quoted hunk ↗ jump to hunk

diff --git a/arch/arm/mach-tegra/clock.c b/arch/arm/mach-tegra/clock.c
index 8d01a49..9798585 100644
--- a/arch/arm/mach-tegra/clock.c
+++ b/arch/arm/mach-tegra/clock.c

@@ -86,6 +86,7 @@ static unsigned long clk_predict_rate_from_parent(struct clk *c, struct clk *p)

? ? ? ?if (c->mul != 0 && c->div != 0) {
? ? ? ? ? ? ? ?rate *= c->mul;
+ ? ? ? ? ? ? ? rate += c->div / 2; /* round up */

Shouldn't this be "rate += c->div - 1;"?



-Olof

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help