[PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros

-----Original Message-----
From: Jamie Iles [mailto:jamie at jamieiles.com]
Sent: Thursday, February 17, 2011 3:01 AM
To: John Linn
Cc: linux-arm-kernel at lists.infradead.org;

linux-kernel at vger.kernel.org; linux at arm.linux.org.uk;

catalin.marinas at arm.com; glikely at secretlab.ca; arnd at arndb.de
Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and

assembly macros

Hi John,

A few more nitpicks, but looking good now!

Jamie

On Wed, Feb 16, 2011 at 09:11:55AM -0700, John Linn wrote:

quoted

These are the minimum needed to build the kernel for the new

platform.

quoted

Signed-off-by: John Linn <redacted>
---

V3 Changes

Updates based on Russell Kings' comments
	Changed headers to update the license info and remove
	the address

	Updated the constant to use UL in vmalloc.h

V2 Changes

Updates based on Russell King's comments
	moved to using entry-macro-gic.S
	moved stuff from hardware.h to xilinx_soc.h
	added IOMEM() in io.h to help with typing
	Minor updates to IO_SPACE_LIMIT and __io()
	Updated addresses to be clear with seperate virtual
		and physical addresses

 arch/arm/mach-xilinx/include/mach/clkdev.h      |   33

++++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/debug-macro.S |   36

+++++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/entry-macro.S |   30

++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/hardware.h    |   18 +++++++++
 arch/arm/mach-xilinx/include/mach/io.h          |   33

++++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/irqs.h        |   29

++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/memory.h      |   23 +++++++++++
 arch/arm/mach-xilinx/include/mach/system.h      |   28

+++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/timex.h       |   24 ++++++++++++
 arch/arm/mach-xilinx/include/mach/uart.h        |   31

+++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/uncompress.h  |   47

+++++++++++++++++++++++

quoted

 arch/arm/mach-xilinx/include/mach/vmalloc.h     |   20 ++++++++++
 arch/arm/mach-xilinx/include/mach/xilinx_soc.h  |   46

++++++++++++++++++++++

quoted

 13 files changed, 398 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-xilinx/include/mach/clkdev.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/debug-macro.S
 create mode 100644 arch/arm/mach-xilinx/include/mach/entry-macro.S
 create mode 100644 arch/arm/mach-xilinx/include/mach/hardware.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/io.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/irqs.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/memory.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/system.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/timex.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/uart.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/uncompress.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/vmalloc.h
 create mode 100644 arch/arm/mach-xilinx/include/mach/xilinx_soc.h

<snip>

quoted

diff --git a/arch/arm/mach-xilinx/include/mach/memory.h

b/arch/arm/mach-xilinx/include/mach/memory.h

quoted

new file mode 100644
index 0000000..c200486

--- /dev/null
+++ b/arch/arm/mach-xilinx/include/mach/memory.h

@@ -0,0 +1,23 @@
+/* arch/arm/mach-xilinx/include/mach/memory.h
+ *
+ *  Copyright (C) 2011 Xilinx
+ *
+ * This software is licensed under the terms of the GNU General

Public

quoted

+ * License version 2, as published by the Free Software Foundation,

and

quoted

+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __MACH_MEMORY_H__
+#define __MACH_MEMORY_H__
+
+#include <mach/hardware.h>
+
+#define PHYS_OFFSET             0x0

This should be PLAT_PHYS_OFFSET and could do with being surrounded

with

UL() e.g.

#define PLAT_PHYS_OFFSET	UL(0x00000000)

This doesn't build with 2.6.38-rc5, am I missing something?

PHYS_OFFSET is still needed from what I can tell, but maybe I overlooked
something.

Thanks,
John


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.