Thread (13 messages) 13 messages, 2 authors, 2011-07-08
STALE5448d

[PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc

From: Ghorai, Sukumar <hidden>
Date: 2011-01-28 08:15:10
Also in: linux-omap

-----Original Message-----
From: Tony Lindgren [mailto:tony at atomide.com]
Sent: Tuesday, January 25, 2011 10:28 PM
To: Ghorai, Sukumar
Cc: linux-omap at vger.kernel.org; linux-mtd at lists.infradead.org; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH RESEND v8 3/7] omap: gpmc: enable irq mode in gpmc

* Ghorai, Sukumar [off-list ref] [110122 09:53]:
quoted
quoted
I think I've commented on this before, but why don't you make
gpmc_init
quoted
quoted
a subsys_initcall? There should be no reason to call this earlier.
If something does not work because of that, then that issue must be
fixed.
[Ghorai] You suggested the same in previous v5 and v6; and I mentioned
the issues [1] that - nand_init()called before
subsys_initcall(gpmc_init);
quoted
Let me know if I am missing anything again.
There should not be any need to call nand_init early either. We want
to initialize as much as possible late so we have proper console
error messages.
[Ghorai] thanks...
changed to postcore_initcall() and it solved the problem I mentioned earlier. And it simplifies the overall modification in different board files.
postcore_initcall(gpmc_init);
Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help