Thread (10 messages) flat view 10 messages, 3 authors, 2011-01-22
DORMANTno replies

Revision v2 of 6 in this series.

Revisions (6)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v2 [diff vs current]
  4. v2 [diff vs current]
  5. v2 [diff vs current]
  6. v2 current

[PATCH 1/3] Support BE8 mode kernel modules relocation

From: Russell King - ARM Linux <hidden>
Date: 2011-01-22 17:00:44

On Fri, Jan 21, 2011 at 06:11:45PM +0800, stanley.miao wrote:
Russell King - ARM Linux wrote:
quoted
On Wed, Jan 19, 2011 at 02:44:45PM +0800, Stanley.Miao wrote:
  
quoted
@@ -174,9 +186,9 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
 			* other bits to re-code instruction as
 			* MOV PC,Rm.
 			*/
-		       *(u32 *)loc &= 0xf000000f;
-		       *(u32 *)loc |= 0x01a0f000;
-		       break;
+			write_instr32((read_instr32(loc) & 0xf000000f) |
+							0x01a0f000, loc);
+			break;
    
Indentation error.

  
Actually, The indentation of my code is right, and the original code is  
wrong.
Yes, you're right.  Please precede your patch which a patch which _just_
corrects the formatting of the old code.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help