On Wed, Jan 19, 2011 at 06:45:00PM +0000, Marc Zyngier wrote:

On Wed, 2011-01-19 at 14:54 +0000, Russell King - ARM Linux wrote:

quoted

On Fri, Jan 07, 2011 at 02:09:51PM +0000, Marc Zyngier wrote:

quoted

As the integrator-flash driver is mostly a duplicate of physmap,
move all users of this driver to physmap and get rid of the
then unused driver.

Does MTD guarantee that the vpp will be turned off whenever the physmap
module is removed?  If not, can it?

Vpp seems to be controlled directly from the chip drivers (using the
{ENABLE,DISABLE}_VPP macros and a command-set specific state machine),
and none of the map drivers play with vpp at all, integrator-flash
included.

By the look of it, it seems pretty safe, though your own experience
seems to indicate otherwise. It should be quite easy to plug the vpp off
feature in physmap. I'll give it a go and re-spin the patchset.

No - we need VPP enabled to write to the flash.  I'm talking about module
removal.  integrator-flash calls back on removal and insertion, where
VPP is controlled at platform level to make sure VPP is turned off.

Also there's the matter of the write enable on Integrator platforms.
That's not the same as VPP - it prevents any write to the flash devices,
even for ID probing.  MTD keeps VPP off during such operations.

So, unless physmap is extended with these callbacks, it can't be used
for Integrator.  So there's no point converting the other platforms.