Thread (5 messages) flat view 5 messages, 2 authors, 2011-01-12
STALE5734d

[PATCH v5 3/3] omap3: beaglexm: fix power on of DVI

From: nm@ti.com (Nishanth Menon)
Date: 2011-01-11 23:55:03
Also in: linux-omap

Tony Lindgren had written, on 01/11/2011 05:23 PM, the following:
[..]
quoted
-
-	gpio_request(gpio + 1, "EHCI_nOC");
-	gpio_direction_input(gpio + 1);
+	if (omap3_beagle_get_rev() != OMAP3BEAGLE_BOARD_XM) {
+		gpio_request(gpio + 1, "EHCI_nOC");
+		gpio_direction_input(gpio + 1);
+	}
The return value for gpio_request must be checked.
Ack.
we can go down two paths:
a) I can redo this patch as in v6.patch (attached)
OR
b) we take this patch and do another one cleaning the function up - 
gpio-check.patch

-- 
Regards,
Nishanth Menon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help