Thread (7 messages) flat view 7 messages, 3 authors, 2011-01-10
STALE5724d

[PATCH] spi: tegra: don't treat NULL clk as an error

From: Russell King - ARM Linux <hidden>
Date: 2011-01-10 22:18:02
Also in: linux-spi

On Mon, Jan 10, 2011 at 01:58:12PM -0700, Grant Likely wrote:
On Mon, Jan 10, 2011 at 4:05 AM, Jamie Iles [off-list ref] wrote:
quoted
Some platforms have been known to return NULL from clk_get() if they
support only a single struct clk. ?Whilst tegra doesn't do this, make
the drivers consistent with others.

Cc: Erik Gilling <redacted>
Signed-off-by: Jamie Iles <redacted>
Hi James,

If NULL does get returned, say due to a future change to the clock
code, then this change causes the driver to oops.  I'm not going to
apply this patch.
Please apply it - the clock API just defines struct clk as a cookie
where errors are IS_ERR/PTR_ERR.  Other values must be considered by
drivers as perfectly valid, including NULL.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help