Thread (19 messages) 19 messages, 4 authors, 2011-02-15
STALE5628d

[PATCH 6/6] Fix eseries compilation if w100fb is not compiled in kernel

From: Uwe Kleine-König <hidden>
Date: 2011-01-05 08:27:49

Hello Dmitry,

On Wed, Jan 05, 2011 at 05:05:10AM +0300, Dmitry Eremin-Solenikov wrote:
quoted hunk ↗ jump to hunk
e800_tg_change depends on w100fb_gpio_read/write API which is only present
if w100fb is compiled in kernel.

Signed-off-by: Dmitry Eremin-Solenikov <redacted>
Cc: Ian Molton <redacted>
---
 arch/arm/mach-pxa/eseries.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-pxa/eseries.c b/arch/arm/mach-pxa/eseries.c
index b25690c..ed2c157 100644
--- a/arch/arm/mach-pxa/eseries.c
+++ b/arch/arm/mach-pxa/eseries.c
@@ -829,6 +829,7 @@ static struct w100_mem_info e800_w100_mem_info = {
 
 static void e800_tg_change(struct w100fb_par *par)
 {
+#ifdef FB_W100
CONFIG_FB_W100?
quoted hunk ↗ jump to hunk
 	unsigned long tmp;
 
 	tmp = w100fb_gpio_read(W100_GPIO_PORT_A);
@@ -837,6 +838,7 @@ static void e800_tg_change(struct w100fb_par *par)
 	else
 		tmp &= ~0x100;
 	w100fb_gpio_write(W100_GPIO_PORT_A, tmp);
+#endif
What happens if FB_W100=m?  The code isn't compiled in, would it still
be necessary?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help