Thread (8 messages) flat view 8 messages, 2 authors, 2011-01-05
STALE5726d

Revision v1 of 2 in this series.

Revisions (2)
  1. v1 [diff vs current]
  2. v1 current

[PATCH 0/2] OMAP: TWL: sparse fixes

From: Russell King - ARM Linux <hidden>
Date: 2011-01-05 00:25:49
Also in: linux-omap

On Tue, Jan 04, 2011 at 02:37:23PM -0600, Nishanth Menon wrote:
hmm.. minor nit (with codesourcery 2010.09-50 - 4.5.1):
rm arch/arm/mach-omap2/*.o;make C=1 arch/arm/mach-omap2/ 2>Kerr;make C=2  
arch/arm/mach-omap2/ 2>Kerr1;diff Kerr Kerr1
[..]
1,4d0
< arch/arm/mach-omap2/mux.c: In function 'omap_mux_get_by_name':
< arch/arm/mach-omap2/mux.c:163:17: warning: 'found_mode' may be used  
uninitialized in this function
< arch/arm/mach-omap2/clkt_clksel.c: In function 'omap2_clksel_set_parent':
< arch/arm/mach-omap2/clkt_clksel.c:100:35: warning: 'max_clkr' may be  
used uninitialized in this function

Kinda interesting to note that C=2 does'nt list all potential gcc  
warnings :( if one wanted a collated list of all warnings, rm .../*.o  
helps I guess.
C=2 only runs sparse - so if you're committing patches to fix sparse
warnings, that's what you should be interested in.

I'd suggest that fixing sparse warnings and GCC warnings in a single
patch is probably not the best thing to do - GCC warnings are less
subjective than sparse warnings.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help