Thread (25 messages) 25 messages, 4 authors, 2011-02-14

[PATCH 1/2] v4l: soc-camera: start stream after queueing the buffers

From: agust@denx.de (Anatolij Gustschin)
Date: 2011-01-29 19:24:11
Also in: linux-media

On Sat, 29 Jan 2011 20:16:42 +0100 (CET)
Guennadi Liakhovetski [off-list ref] wrote:
...
quoted
--- a/drivers/media/video/soc_camera.c
+++ b/drivers/media/video/soc_camera.c
@@ -646,11 +646,11 @@ static int soc_camera_streamon(struct file *file, void *priv,
 	if (icd->streamer != file)
 		return -EBUSY;
 
-	v4l2_subdev_call(sd, video, s_stream, 1);
-
 	/* This calls buf_queue from host driver's videobuf_queue_ops */
 	ret = videobuf_streamon(&icd->vb_vidq);
 
+	v4l2_subdev_call(sd, video, s_stream, 1);
+
After a bit more testing I'll make this to

+	if (!ret)
+		v4l2_subdev_call(sd, video, s_stream, 1);
+

Ok? Or you can submit a v2 yourself, if you like - when you fix the 
comment in the other patch from this series.
I'll submit a v2 patch since I have to resubmit the other patch, too.


Thanks,
Anatolij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help