[PATCH V2] ST SPEAr: PCIE gadget suppport

On Fri, Jan 07, 2011 at 02:27:01PM +0530, pratyush wrote:

On 1/7/2011 12:18 AM, Greg KH wrote:

quoted

On Thu, Jan 06, 2011 at 05:29:10PM +0530, Viresh Kumar wrote:

quoted

From: Pratyush Anand <redacted>

This is a configurable gadget. can be configured by sysfs interface. Any
IP available at PCIE bus can be programmed to be used by host
controller.It supoorts both INTX and MSI.
By default, gadget is configured for INTX and SYSRAM1 is mapped to BAR0
with size 0x1000

Changes since V1:
- __iomem added for register addresses
- kerneldoc comment removed whereever not required.
- help node moved from sysfs to documentation/misc-devices
- strict_strtoul used instead of sscanf

Signed-off-by: Pratyush Anand <redacted>
Signed-off-by: Viresh Kumar <redacted>
---
 Documentation/misc-devices/spear-pcie-gadget.txt |  125 ++++

New sysfs entries require updates to the Documentation/ABI/ directory
for them.

Please rework the patch to include these entries.

Ok..will send [Patch V3] with these modifications.
But, are these rework needed if I move this interface to configfs
as you have suggested below.
Or is there some different directory where documentation for configfs
node can be mentioned?

Nope, same directory, you are still creating a user/kernel ABI by using
configfs right?  It needs to be documented just as well.

thanks,

greg k-h