Hello, Mr. Kukjin.

I am on vacation until this sunday.
Could you please give me your reviews?

If you give me your comments about my patch series then I will re-work
them on Monday.
by doing so, we could save the time.

thank you.

2010/12/29 Kukjin Kim [off-list ref]:

Inki Dae wrote:

quoted

Please keep myself in Cc on this. I already noticed that to you before.
I think you should check whether mail loop is suitable or not...

And would be better if you could add #0 patch to understand your patches.

quoted

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
?arch/arm/mach-s5pv210/include/mach/regs-clock.h | ? ?6 +++++-
?1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-s5pv210/include/mach/regs-clock.h

b/arch/arm/mach-

quoted

s5pv210/include/mach/regs-clock.h
index ebaabe0..09680d9 100644

--- a/arch/arm/mach-s5pv210/include/mach/regs-clock.h
+++ b/arch/arm/mach-s5pv210/include/mach/regs-clock.h

@@ -146,6 +146,7 @@

?#define S5P_OM_STAT ? ? ? ? ?S5P_CLKREG(0xE100)
?#define S5P_USB_PHY_CONTROL ?S5P_CLKREG(0xE80C)
?#define S5P_DAC_CONTROL ? ? ? ? ? ? ?S5P_CLKREG(0xE810)
+#define S5P_MIPI_DPHY_CONTROL ? ? ? ? ? ? ? ?S5P_CLKREG(0xE814)

?#define S5P_INFORM0 ? ? ? ? ?S5P_CLKREG(0xF000)
?#define S5P_INFORM1 ? ? ? ? ?S5P_CLKREG(0xF004)

@@ -196,7 +197,10 @@

?#define S5P_OTHERS_USB_SIG_MASK ? ? ? ? ? ? ?(1 << 16)

?/* MIPI */
-#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3)
+#define S5P_MIPI_DPHY_EN ? ? ? ? ? ? (3 << 0)
+
+/* S5P_MIPI_PHY_CON0 */
+#define S5P_MIPI_M_RESETN ? ? ? ? ? ?(1 << 1)

?/* S5P_DAC_CONTROL */
?#define S5P_DAC_ENABLE ? ? ? ? ? ? ? ? ? ? ? (1)
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel