[PATCH] ARM: mxs: Change duart device to use amba-pl011

Hi Wolfram,

Thanks for the review.

On Tue, Dec 21, 2010 at 09:31:21PM +0100, Wolfram Sang wrote:

Hi Shawn,

On Tue, Dec 21, 2010 at 09:12:10PM +0800, Shawn Guo wrote:

quoted

The mxs duart is actually an amba-pl011 device. This commit changes
the duart device code to dynamically allocate amba-pl011 device,
so that drivers/serial/amba-pl011.c can be used on mxs.

Signed-off-by: Shawn Guo <redacted>

Great that it works!

[...]

quoted

 static struct clk_lookup lookups[] = {
-	_REGISTER_CLOCK("mxs-duart.0", NULL, uart_clk)
+	_REGISTER_CLOCK("uart", NULL, uart_clk)

Maybe "duart"?

I was thinking about the naming "uart" vs "duart" here, and decided to
pick the "uart", because this is the name of clock "uart_clk", which
is the clock for uart domain, not only duart.

[...]

quoted

+#include <mach/mx23.h>
+#include <mach/mx28.h>
+#include <mach/devices-common.h>
+
+#define MXS_AMBA_DEVICE(name, soc)				\

Maybe MXS_AMBA_DUART_DEVICE? It now sounds more generic than it actually is ;)

OK. Will change.

-- 
Regards,
Shawn