Thread (1 message) 1 message, 1 author, 2010-10-07
STALE5765d

[PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

From: Vimal Singh <hidden>
Date: 2010-10-07 17:39:49
Also in: linux-omap

On Tue, Sep 21, 2010 at 3:31 PM, G, Manjunath Kondaiah [off-list ref] wrote:
Following sparse warnings exists due to use of writel/w and readl/w functions.

This patch fixes the sparse warnings by converting readl/w functions usage into
__raw_readl/__raw_readw functions.
[...]
quoted hunk
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -481,7 +481,7 @@ static int omap_verify_buf(struct mtd_info *mtd, const u_char * buf, int len)
? ? ? ?len >>= 1;
? ? ? ?while (len--) {
- ? ? ? ? ? ? ? if (*p++ != cpu_to_le16(readw(info->nand.IO_ADDR_R)))
+ ? ? ? ? ? ? ? if (*p++ != cpu_to_le16(__raw_readw(info->nand.IO_ADDR_R)))
There was an old comment to remove use of 'cpu_to_le16' from driver, I
just missed it. Can you rather use 'ioread16_rep' for reading data.

-- 
Regards,
Vimal Singh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help