Thread (11 messages) 11 messages, 6 authors, 2010-09-30
DORMANTno replies

[PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init

From: Varadarajan, Charulatha <hidden>
Date: 2010-09-30 17:06:42
Also in: linux-omap

Possibly related (same subject, not in this thread)

quoted
Tony/ Benoit,
quoted
quoted
I think that disabling it should be done only if the CONFIG_OMAP_WDT
is not set.
How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT
is set?
As given in the patch description, this patch does a disable of watchdog
timer, during init, to avoid the system rebooting that happens due to
enabling of watchdog timer after a reset of the module (during hwmod init).

According to the default WDT registers values, the system reboot would
happen in ~10s if watchdog is enabled with default values. Hence, after
a WDT module reset during init, the watchdog has to be disabled within 10s
otherwise the system will keep rebooting.

Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT,
the watchdog timer needs to be disabled after a WDT reset has happened.
No, not necessarily, this is the whole point about a watchdog, you need
just need to ping it to prove that the system is alive.
Agreed
In case you didn't notice, every watchdogs are started during a cold
reset since OMAP1610. Even Phoenix contains a watchdog that is started
by default.
This is by construction... and this is done like that for a good reason.
Yes.
So stopping a watchdog just after the reset in a bootloader is not
necessarily the behavior that user of a watchdog are expecting,
otherwise it will not be started by default at boot time.
But, how do we handle this? enable INIT_NO_RESET flag?
In your description, it looks like this behavior is a HW bug that we
have to fix...
Sorry if it sounded like that. 
It is just the way it is supposed to work.
Yes. That's correct

Regards,
Benoit
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help