On Thu, Sep 30, 2010 at 3:50 PM, Jassi Brar [off-list ref] wrote:

quoted

On Thu, Sep 30, 2010 at 3:27 PM, Kyungmin Park [off-list ref] wrote:

quoted

On Thu, Sep 30, 2010 at 3:20 PM, Jeongbae Seo [off-list ref]

wrote:

quoted

quoted

quoted

Kyungmin wrote:

quoted

From: Kyungmin Park <kyungmin.park@samsung.com>

S5PC210 support more I2C devices than previous SoCs.
And to prevent the wrong usage use the s5p prefix instead of s3c.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
?arch/arm/mach-s5pv310/Kconfig ? ? ? ? ? ?| ? 15 +++++++
?arch/arm/mach-s5pv310/Makefile ? ? ? ? ? | ? ?5 ++
?arch/arm/mach-s5pv310/setup-i2c3.c ? ? ? | ? 25 +++++++++++
?arch/arm/mach-s5pv310/setup-i2c4.c ? ? ? | ? 25 +++++++++++
?arch/arm/mach-s5pv310/setup-i2c5.c ? ? ? | ? 25 +++++++++++
?arch/arm/mach-s5pv310/setup-i2c6.c ? ? ? | ? 25 +++++++++++
?arch/arm/mach-s5pv310/setup-i2c7.c ? ? ? | ? 25 +++++++++++
?arch/arm/plat-s5p/Kconfig ? ? ? ? ? ? ? ?| ? 25 +++++++++++
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? | ? ?5 ++
?arch/arm/plat-s5p/dev-i2c3.c ? ? ? ? ? ? | ? 67
++++++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c4.c ? ? ? ? ? ? | ? 67
++++++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c5.c ? ? ? ? ? ? | ? 67
++++++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c6.c ? ? ? ? ? ? | ? 67
++++++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c7.c ? ? ? ? ? ? | ? 67
++++++++++++++++++++++++++++++
?arch/arm/plat-samsung/include/plat/iic.h | ? ?5 ++
?15 files changed, 515 insertions(+), 0 deletions(-)
?create mode 100644 arch/arm/mach-s5pv310/setup-i2c3.c
?create mode 100644 arch/arm/mach-s5pv310/setup-i2c4.c
?create mode 100644 arch/arm/mach-s5pv310/setup-i2c5.c
?create mode 100644 arch/arm/mach-s5pv310/setup-i2c6.c
?create mode 100644 arch/arm/mach-s5pv310/setup-i2c7.c
?create mode 100644 arch/arm/plat-s5p/dev-i2c3.c
?create mode 100644 arch/arm/plat-s5p/dev-i2c4.c
?create mode 100644 arch/arm/plat-s5p/dev-i2c5.c
?create mode 100644 arch/arm/plat-s5p/dev-i2c6.c
?create mode 100644 arch/arm/plat-s5p/dev-i2c7.c

Hi Kyungmin,

We are considering another way not to make additional new i2c dev files.
In my opinion, this patch looks not bad but we'd better make an effort to
avoid having the more similar file.

Actually I also it's not good approach, but as there's no comment or
discuss about this I send the patches.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-

August/022615.html

quoted

quoted

If you have good method or approaches, I'm welcome.

First, these are device definitions and gpio set callbacks and
shouldn't take much
of space. So, perhaps these all could be built upon single I2C support
selection.

That's my first propose.

Hi, Kyungmin and Jassi

I think that parts of i2c in S5PV310 aren't used depending on the usage of
S5PV310.
It's better define the number of i2c devs being used instead of using single I2C
support selection.

quoted

Second, if we must build them conditionally, how about having all in
one file with
each device's definition and callback surrounded by corresponding ifdef ?
That would alteast save us file-count.

This method is also no problem if all of person are agreed.

So just choose it and make a conclusion.

Thank you,
Kyungmin Park

quoted

I agree with Jassi's opinion keeping setup-i2c(0..2) and dev-i2c(0..2) for
backward
compatibility and adding a file which handles i2c(0..7) for S5PV310 and coming
Samsung
soc.

Best Regards
Jongsun Han