On Fri, Sep 24, 2010 at 6:17 PM, Premi, Sanjeev [off-list ref] wrote:

quoted

On Fri, Sep 24, 2010 at 4:50 AM, Tony Lindgren
[off-list ref] wrote:

quoted

From: Yogesh Marathe <redacted>

The definition of "iva2" device in iommu_device
is wrapped inside CONFIG_MPU_BRIDGE_IOMMU, but
this option is not defined in KConfig.

This patch removes the wrapper and makes "iva2"
available as another iommu_device.

NAK.

This would break tidspbridge's MMU. This was discussed before:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/58302/focus=58305

When tidspbridge has migrated to iommu, then it should define
CONFIG_MPU_BRIDGE_IOMMU.

?Can you go through earlier discussion on this patch
?http://marc.info/?l=linux-omap&m=127979007623260&w=2

?I believe these concerns were discussed. I am unable to
?open the gmane thread (getting 504) - so can't be sure
?if Hiroshi had referred to same discussion.

When you merge iommu support, then either you enable
CONFIG_MPU_BRIDGE_IOMMU unconditionally, or you apply this patch, but
this patch alone will only break things.

-- 
Felipe Contreras