Thread (1 message) 1 message, 1 author, 2010-09-16
DORMANTno replies

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

From: Kevin Hilman <hidden>
Date: 2010-09-16 18:01:07
Also in: linux-omap

"Shilimkar, Santosh" [off-list ref] writes:
quoted
-----Original Message-----
From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
owner at vger.kernel.org] On Behalf Of Menon, Nishanth
Sent: Thursday, September 16, 2010 10:40 PM
To: Linus Walleij
Cc: Kevin Hilman; linux-omap at vger.kernel.org; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH 1/4] OMAP: introduce OPP layer for device-specific
OPPs

Linus Walleij had written, on 09/16/2010 12:07 PM, the following:
quoted
2010/9/16 Kevin Hilman [off-list ref]:
quoted
lib/opp/* seems more appropriate to me with the header at
include/linux/opp.h as Linus suggested.
I second this. I would love to see the generic OPP stuff in
lib/opp/* so we put it in the right place from the beginning and
don't have to painfully refactor everything later (clk.h
especially comes to mind.)
cool.. digging a bit deeper into lib directory, I propose the following:
lib/opp.c
include/linux/opp.h

any soc specific data (for registration etc) -> goes to
arch/<arch>/mach-<soc>/oppdata_xyz.c or what ever they choose

the intent being lib/ is no place to put mach or arch specific data
definitions.. it is just noise..

if folks are ok with this, will post a new rev soonish..
If you like may be you can take this thread over lkml just to get more
wider perspective
I propose Nishanth does the slight rework to move this to lib/ and then
post to l-o, l-a-k and lkml for RFC.  Note that only the generic parts
should be posted first, the OMAP specific usage of this can be fixed
after the generic parts are accepted.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help