Thread (18 messages) flat view 18 messages, 4 authors, 2010-09-14
STALE5850d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 6/6] ARM: S5PC110: add support for MMC regulators on Goni board

From: Mark Brown <hidden>
Date: 2010-09-10 09:41:04
Also in: linux-samsung-soc

On Fri, Sep 10, 2010 at 09:23:23AM +0200, Marek Szyprowski wrote:
+static struct regulator_consumer_supply goni_ldo5_consumers[] = {
+	{ .supply = "vmmc",	.dev = &s3c_device_hsmmc0.dev },
+};
+
This is OK but it is better to use dev_name rather than dev - dev may
be removed at some point since given dev you can always use dev_name but
you don't always have dev.

Acked-by: Mark Brown <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help