[PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337

Dne St 8. z??? 2010 19:05:02 Mark F. Brown napsal(a):

On Wed, Sep 8, 2010 at 11:54 AM, Marek Vasut [off-list ref] wrote:

quoted

Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):

quoted

On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown [off-list ref]

wrote:

quoted

quoted

Signed-off-by: Mark F. Brown <redacted>
---
 arch/arm/mach-mmp/teton_bga.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mmp/teton_bga.c

b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644

--- a/arch/arm/mach-mmp/teton_bga.c
+++ b/arch/arm/mach-mmp/teton_bga.c

@@ -22,6 +22,7 @@
 #include <mach/gpio.h>
 #include <linux/input.h>
 #include <plat/pxa27x_keypad.h>
+#include <linux/i2c.h>

 #include "common.h"

@@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[]

__initdata = { GPIO110_KP_MKIN0,
       GPIO111_KP_MKOUT7,
       GPIO112_KP_MKOUT6,
+
+       /* i2c bus */
+       GPIO105_CI2C_SDA,
+       GPIO106_CI2C_SCL,
 };

 static unsigned int teton_bga_matrix_key_map[] = {

@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data

teton_bga_keypad_info __initdata = { .debounce_interval      = 30,
 };

+static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
+       { I2C_BOARD_INFO("ds1337", 0x68), },
+};
+

I don't have the schematic of teton. But RTC chips should always has
an irq pin. Is it also connected in your platform?

I think this one doesn't, but I haven't checked.

Cheers

quoted

quoted

 static void __init teton_bga_init(void)
 {
       mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));

@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
       /* on-chip devices */
       pxa168_add_uart(1);
       pxa168_add_keypad(&teton_bga_keypad_info);
+       pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
 }

 MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development

Platform") --
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

It actually does have an alarm pin and it is connected as well. I did
not include it, because I have not tested the alarm functionality yet.
I was going to add it in a later patch. I did test the hardware clock
to system clock syncing.

Fix the CC please. And be careful not to screw this up again next time.

Please add the alarm pin too. Thanks

Cheers

Regards,
-- Mark