[RESEND PATCH] serial: samsung: fix device name
From: ben-linux@fluff.org (Ben Dooks)
Date: 2010-09-23 23:40:49
Also in:
linux-serial, lkml
On 23/09/10 20:15, Darius Augulis wrote:
Swap device and driver names in serial/samsung.c
This is far too short, please see the notes below on trying to make this more informative.
Signed-off-by: Darius Augulis <redacted> --- This patch was submitted about 3 months ago, but still not merged. There was another similar patch from Joonyoung Shim [off-list ref] and was discussed here: http://marc.info/?l=linux-serial&m=127416101222281&w=2. Joonyoung Shim acked my patch and other people on ARM mailing list acked it. The maintainer, Ben Dooks, still not responding for a long time. Another maintainer, Kukjin Kim, refused to merge it without Ben's review. I would like to ask somebody pick up this bugfix.
I belive last time this was brought up I asked about the affect this has on the userspace. The following issues would be helpful or essential to have noted in the header about the effect of this. - Does it change the /dev name of the device? if so I would thinl carefully about applying it, as it would be a change in the way that userspace sees the kernel. - Does it change the kernel output itself? A note on what diffeences can be seen in things like dmesg would be helpful. - Are there any other side effects - Why is this a bug? Maybe the previous points will explain what is going on, but if not, then a reasonably concise description of what is going on here.
quoted hunk ↗ jump to hunk
drivers/serial/samsung.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c index b1156ba..25c0d0f 100644 --- a/drivers/serial/samsung.c +++ b/drivers/serial/samsung.c@@ -883,10 +883,10 @@ static struct uart_ops s3c24xx_serial_ops = { static struct uart_driver s3c24xx_uart_drv = { .owner = THIS_MODULE, - .dev_name = "s3c2410_serial", + .driver_name = "s3c2410_serial", .nr = CONFIG_SERIAL_SAMSUNG_UARTS, .cons = S3C24XX_SERIAL_CONSOLE, - .driver_name = S3C24XX_SERIAL_NAME, + .dev_name = S3C24XX_SERIAL_NAME, .major = S3C24XX_SERIAL_MAJOR, .minor = S3C24XX_SERIAL_MINOR, };_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel