[PATCH 2/8] ARM i.MX dma-mx1-mx2: use wrapper

On Mon, Aug 09, 2010 at 08:51:01PM +0200, Magnus Lilja wrote:

Hi Sascha,

quoted

diff --git a/arch/arm/mach-imx/dma-v1.c b/arch/arm/mach-imx/dma-v1.c
index 3e8c47c..d141458 100644
--- a/arch/arm/mach-imx/dma-v1.c
+++ b/arch/arm/mach-imx/dma-v1.c

@@ -35,6 +35,7 @@

...

quoted

@@ -503,7 +517,7 @@ void imx_dma_disable(int channel)
 	struct imx_dma_channel *imxdma = &imx_dma_channels[channel];
 	unsigned long flags;
 
-	pr_debug("imxdma%d: imx_dma_disable\n", channel);
+	pr_info("imxdma%d: imx_dma_disable\n", channel);

With this change imx_dma_enable() uses pr_debug() while
imx_dma_disable uses pr_info(). Shouldn't both use the same pr_*()
since the functions are paired?

They should both use pr_debug. Will fix.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |