Joonyoung Shim wrote:

On 8/6/2010 3:47 PM, Paulius Zaleckas wrote:

quoted

On 08/06/2010 03:04 AM, Kyungmin Park wrote:

quoted

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

Darius patch is a little bit cleaner.

OK, it's better.

Acked-by: Joonyoung Shim <redacted>

Hi all,

I think, this should be handled by Ben Dooks....
As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:

On 5/18/2010 11:48 AM, Ben Dooks wrote:

quoted

On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:

quoted

Thd dev_name and driver_name should be switched each other.

Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
 
Please provide some information about what problem that this is fixing
and the impact on any existing systems.

The serial device nodes are created to s3c2410_serial* on android 
platform instead of ttySAC*.

This has been how they've been for ages, surely the android device node
creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
like many other operating sysyerms that can already do this.

Changing this just because android (something as-yet unmerged into mainline)
does not like it. I'm not even happy with an #ifdef around this.

If you really feel this is a problem that you absolutely must fix in kernel
then please provide a kernel commandline option to change the serial driver
name and use that on any platform that needs it. Another way would be to
update the serial platform data to have a field for which name to choose.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

===

quoted

quoted

As discussed with Ben. even though it's right patch, there's some
users to use previous interface.
I also think it will be fixed. but need to coordinate with existing
users.

IMO this is obvious bug fix.

Acked-by: Paulius Zaleckas <redacted>

quoted

Ben, how to you think?

On Fri, Aug 6, 2010 at 5:10 AM, Darius
Augulis[off-list ref]  wrote:

quoted

Swap device and driver names in serial/samsung.c

Signed-off-by: Darius Augulis<redacted>
---
  drivers/serial/samsung.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
index a9d6c56..9d63f24 100644
--- a/drivers/serial/samsung.c
+++ b/drivers/serial/samsung.c

@@ -878,10 +878,10 @@ static struct uart_ops s3c24xx_serial_ops = {

  static struct uart_driver s3c24xx_uart_drv = {
        .owner          = THIS_MODULE,
-       .dev_name       = "s3c2410_serial",
+       .driver_name    = "s3c2410_serial",
        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,
        .cons           = S3C24XX_SERIAL_CONSOLE,
-       .driver_name    = S3C24XX_SERIAL_NAME,
+       .dev_name       = S3C24XX_SERIAL_NAME,
        .major          = S3C24XX_SERIAL_MAJOR,
        .minor          = S3C24XX_SERIAL_MINOR,
  };

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.