[PATCH] PXA: Fix wakealarm capability for pxa-rtc

From
Marek Vasut <hidden>
Date
2010-08-01 15:38:16
Reply to
Robert Jarzmik, 2010-08-01
Dne Ne 1. srpna 2010 13:15:13 Robert Jarzmik napsal(a):
Marek Vasut [off-list ref] writes:
quoted
Dne Ne 1. srpna 2010 02:48:38 Robert Jarzmik napsal(a):
quoted
Marek Vasut [off-list ref] writes:
quoted
Dne So 31. ?ervence 2010 23:07:06 Robert Jarzmik napsal(a):
quoted
Marek Vasut [off-list ref] writes:
quoted
Dne So 31. ?ervence 2010 17:38:06 Robert Jarzmik napsal(a):
quoted
Marek Vasut [off-list ref] writes:
quoted
The wakealarm capability was incorrectly set after the RTC was
registered, which resulted into the sysfs node not being
created.
On my platform, without this patch:
quoted
cat /sys/devices/platform/pxa-rtc/power/wakeup
enabled
The sysfs node is created. What's the issue you're having ?
It's not created for me without this patch (and if you read the
code, it is impossible to be created without this patch).
Are we talking about the same /sys/devices/platform/pxa-rtc/power/wakeup
? Aren't you looking for /sys/class/rtc/rtc0/power/wakeup ?
I'm looking for /sys/class/rtc/rtc0/wakealarm
Okay, I understand better, you're looking for the class driver wakup sysfs
entry, and not the driver sysfs wakeup entry.

So when you said "It's not created for me without this patch", you meant
the class driver's sysfs entry, not the one I mentioned I presume ?
You're still talking about some "wakeup", I'm talking about 
/sys/devices/platform/pxa-rtc/power/wakealarm .
Anyway, to straighten things up :
 - for an rtc driver, device_init_wakeup() has to be called before
 rtc_driver_register()
 - if that's not the case, /sys/class/rtc/rtc0/wakealarm won't be created
 - if that's the case, if the driver called device_init_wakeup(x, 1), the
rtc registering will override the value with device_init_wakeup(x, 0)
Are we talking about the same kernel? I just can't find this 
"device_init_wakeup(x, 0);" which would override anything anywhere.
I don't think changing the current behaviour, ie. having by default the rtc
driver *not* wake up from suspend is a good thing.
Huh?
As I see now your real
problem, I would request you leave the existing "device_init_wakeup(x, 1)"
*and* you add yours to make the class driver happy.
Why wouldn't the driver wake up from suspend?
Cheers.

--
Robert
Thread (6 messages) 6 messages, 3 authors, last reply 2010-08-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help