Joonyoung Shim wrote:

Hi, Dmitry.

On 7/9/2010 4:39 PM, Joonyoung Shim wrote:

quoted

On 7/9/2010 4:07 PM, Kukjin Kim wrote:

quoted

Joonyoung Shim wrote:

quoted

On 7/7/2010 8:52 AM, Kukjin Kim wrote:

quoted

Joonyoung Shim wrote:

quoted

Hi, Naveen.

On 6/28/2010 8:33 PM, Joonyoung Shim wrote:

quoted

This patch adds support for keypad driver running on Samsung cpus. This
driver is tested on GONI and Aquila board using S5PC110 cpu.

Signed-off-by: Joonyoung Shim <redacted>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/input/keyboard/Kconfig          |    9 +
 drivers/input/keyboard/Makefile         |    1 +
 drivers/input/keyboard/samsung-keypad.c |  491

+++++++++++++++++++++++++++++++

quoted

 3 files changed, 501 insertions(+), 0 deletions(-)
 create mode 100644 drivers/input/keyboard/samsung-keypad.c

Could you please test this v6 keypad driver on your various targets?

Hi,

I received the test result from Naveen.
And now he is debugging about that.

..his e-mail client has some problem..so I replied...

---
From: Naveen Ch

I've tested with v6 patches and they are working fine on SMDK6410,

SMDKC100

quoted

quoted

quoted

and SMDKV210, except for some header inclusion (linux/sched.h) in

samsung-

quoted

quoted

quoted

keypad.c.

quoted

The build breaking error is like following:
(make s5pc100_defconfig and select input->keypad->samsung keypad)

drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq':
drivers/input/keyboard/samsung-keypad.c:170: error:

'TASK_UNINTERRUPTIBLE'

quoted

quoted

quoted

undeclared (first use in this function)

quoted

drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared

identifier

quoted

quoted

quoted

is reported only once

quoted

drivers/input/keyboard/samsung-keypad.c:170: error: for each function it

appears

quoted

quoted

quoted

in.)

quoted

drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of

function 'schedule_timeout'

quoted

drivers/input/keyboard/samsung-keypad.c: In function

'samsung_keypad_stop':

quoted

quoted

quoted

quoted

drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL'

undeclared (first use in this function)

quoted

make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1

This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT
option. I think sched.h should be included to remove like this
dependency in driver, are there other ways?

I'm not sure root cause is that. But as you said, I think need inclusion it for

prevent the problem.

quoted

quoted

Actually didn't happen it before..so maybe the some core functions have

moved between rc-3 and earlier versions...

quoted

The sched.h is included by below path.

interrupt.h -> hardirq.h -> smp_lock.h -> sched.h

The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined.
The samsung keypad driver haven't needed including sched.h before
Dmitry's patch is applied..

quoted

Anyway, if no any issues, could you please re-submit updated it soon?

I haven't get yet Dmitry's review of v6 patch set, so i am waiting it.

Ping.

Do you have any feedback? If ok, i want to go to input tree or samsung
tree these added sched.h including.

With including sched.h and Naveen's keypad support patches for SMDK6410, SMDKC100 and SMDKV210:

[ch.naveen at samsung.com: tested on SMDK6410, SMDKC100, and SMDKV210]
Tested-by: Naveen Krishna Ch <redacted>
Acked-by: Kukjin Kim <redacted>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim [off-list ref], Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.