Op 30-06-10 12:39, Kukjin Kim schreef:

Maurus Cuelenaere wrote:
Hi Maurus :-)

Hi Kukjin

quoted

 Op 29-06-10 13:05, Kukjin Kim schreef:

quoted

From: Abhilash Kesavan <redacted>

Adds support for the Samsung PATA controller. This driver is based on the
Libata subsystem and references the earlier patches sent for IDE subsystem.

Signed-off-by: Abhilash Kesavan <redacted>
Signed-off-by: Kukjin Kim <redacted>
Cc: Ben Dooks <ben-linux@fluff.org>

<snip>

quoted

quoted

+/*
+ * Waits until the IDE controller is able to perform next read/write
+ * operation to the disk. Needed for 64XX series boards only.
+ */
+static int wait_for_host_ready(struct s3c_ide_info *info)
+{
+	ulong timeout;
+	void __iomem *fifo_reg = info->ide_addr + info->fifo_status_reg;
+

Shouldn't this have an if (type != S3C64XX) return 0; ?

Actually, wait_for_host_ready() is called only by pata_s3c_port_ops methods 

Oh, ok. Sorry for the noise.

-- 
Maurus Cuelenaere