[PATCH 6/6] omap2/3/4: Add Kconfig option to compile in typical omap features
From: tony@atomide.com (Tony Lindgren)
Date: 2010-06-30 06:17:26
Also in:
linux-omap
From: tony@atomide.com (Tony Lindgren)
Date: 2010-06-30 06:17:26
Also in:
linux-omap
* Shilimkar, Santosh [off-list ref] [100629 17:40]:
quoted
quoted
With your series OMAP4 build breaks because of PM and SMP dependencies. To ensure that build doesn't break on OMAP4, I needed below change. With This change I tried your series and it boots OK on OMAP4430 SDP
Hmm the build does not break for me?
Also tested the multi-omap build on OMAP3430 SDP and OMAP4430 SDP. Both boots OK.quoted
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 84fecd0..f48f275 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig@@ -7,8 +7,8 @@ config ARCH_OMAP2PLUS_TYPICAL default y select AEABI select REGULATOR - select PM - select PM_RUNTIME + select PM if !ARCH_OMAP4 + select PM_RUNTIME if !ARCH_OMAP4 select VFP select NEON if ARCH_OMAP3 || ARCH_OMAP4 select SERIAL_8250
Let's rather fix whatever the issue is for booting (or building?) omap4 with CONFIG_PM and CONFIG_PM_RUNTIME. If we can't implement PM yet for omap4, we can just return early if cpu_is_omap44xx. CONFIG_SMP we can't enable as that requires various ARM changes to work on unicore systems. But hopefully we can enable that too at some point with select SMP if ARCH_OMAP4. Regards, Tony