Thread (6 messages) 6 messages, 4 authors, 2010-06-22
STALE5880d

[PATCH V2] GPIO PL061: Adding Clk framework support

From: Rabin Vincent <hidden>
Date: 2010-06-21 15:41:21

On Mon, Jun 21, 2010 at 12:27:43PM +0530, Viresh KUMAR wrote:
GPIO Clk is never enabled on Platforms, like: SPEAr, which are based upon clock
framework and use PL061 driver. This patch adds support for Clk enabling and
disabling as and when gpios are requested and freed.
[...]
+	chip->clk = clk_get(&dev->dev, NULL);
+	if (IS_ERR(chip->clk)) {
+		ret = PTR_ERR(chip->clk);
+		goto iounmap;
+	}
Have you verified that all platforms using this driver already have
clocks with the appropriate names?   Otherwise this patch will break
those platforms.

Rabin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help