Thread (39 messages) 39 messages, 9 authors, 2010-04-18
STALE5741d

[PATCH 2/3] i2c/pxa: only define 'blue_murder'-function if DEBUG is #defined

From: Russell King - ARM Linux <hidden>
Date: 2010-02-28 15:55:02
Also in: linux-i2c

On Wed, Feb 24, 2010 at 12:01:45PM +0100, Uwe Kleine-K?nig wrote:
From: Wolfram Sang <redacted>

This talkative function is also called on timeouts. As timeouts can
happen on regular writes to EEPROMs (no error case), this creates false
positives.  Giving lots of details is interesting only for developers
anyhow, so just use the function if DEBUG is #defined.
Are you sure this is safe?  If you time out the write before it completes,
how do you know if the write was successful?

I don't think this is "no error code" nor "false positive".  If the timeout
is too short for your EEPROMs, then the timeout needs to be increased.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help