Thread (1 message) 1 message, 1 author, 2009-11-16
DORMANTno replies

[PATCH v2 26/32] OMAP3: PM debug: allow runtime toggle of PM features

From: Kevin Hilman <hidden>
Date: 2009-11-16 18:31:34
Also in: linux-omap

"Gopinath, Thara" [off-list ref] writes:

[...]
quoted
quoted
+void omap3_pm_off_mode_enable(int enable)
+{
+	struct power_state *pwrst;
+	u32 state;
+
+	if (enable)
+		state = PWRDM_POWER_OFF;
+	else
+		state = PWRDM_POWER_RET;
+
+	list_for_each_entry(pwrst, &pwrst_list, node) {
+		pwrst->next_state = state;
+		set_pwrdm_state(pwrst->pwrdm, state);
Shld the next states of MPU and CORE domain also be changed? 
No.  MPU & CORE are handled by CPUidle, and there the enable_off_mode
flag is checked.
It should happen only in idle thread or system suspend path. Not at
any arbit point where user sets enable_off_mode.
Why not?  

If the domain is idle, it is turned off immediately.  If it's not idle,
it doesn't transition until it is.

Kevin
<
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help