Re: [PATCH] tools/memory-model: Provide extra ordering for unlock+lock pair on the same CPU
From: Palmer Dabbelt <palmer@dabbelt.com>
Date: 2021-10-08 16:33:05
Also in:
lkml
From: Palmer Dabbelt <palmer@dabbelt.com>
Date: 2021-10-08 16:33:05
Also in:
lkml
On Thu, 07 Oct 2021 23:54:23 PDT (-0700), boqun.feng@gmail.com wrote:
On Fri, Oct 08, 2021 at 04:30:37PM +1100, Michael Ellerman wrote:quoted
Boqun Feng [off-list ref] writes:quoted
(Add linux-arch in Cc list) Architecture maintainers, this patch is about strengthening our memory model a little bit, your inputs (confirmation, ack/nack, etc.) are appreciated.Hi Boqun, I don't feel like I'm really qualified to give an ack here, you and the other memory model folk know this stuff much better than me. But I have reviewed it and it matches my understanding of how our barriers work, so it looks OK to me. Reviewed-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
I'm basically in the same spot. I think I said something to that effect somewhere in the thread, but I'm not sure if it got picked up so Acked-by: Palmer Dabbelt <redacted> (RISC-V) (I don't feel comfortable reviewing it so I'm acking it, not sure if I'm just backwards about what all this means though ;)). IIUC this change will mean the RISC-V port is broken, but I'm happy to fix it. Were you guys trying to target this for 5.16?