Re: [PATCH] MIPS: fix local_t operation on MIPS64
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
Date: 2021-09-04 17:58:02
Also in:
linux-mips, linux-mm
Possibly related (same subject, not in this thread)
- 2021-09-08 · Re: [PATCH] MIPS: fix local_t operation on MIPS64 · 黄沛 <hidden>
- 2021-09-07 · Re: [PATCH] MIPS: fix local_t operation on MIPS64 · "Maciej W. Rozycki" <macro@orcam.me.uk>
- 2021-09-06 · Re: [PATCH] MIPS: fix local_t operation on MIPS64 · "Maciej W. Rozycki" <macro@orcam.me.uk>
- 2021-09-06 · Re: [PATCH] MIPS: fix local_t operation on MIPS64 · "Maciej W. Rozycki" <macro@orcam.me.uk>
- 2021-09-04 · Re: [PATCH] MIPS: fix local_t operation on MIPS64 · kernel test robot <hidden>
On Sat, 4 Sep 2021, Huang Pei wrote:
quoted hunk
diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h index ec09fe5d6d6c..788e26ad7fca 100644 --- a/arch/mips/include/asm/llsc.h +++ b/arch/mips/include/asm/llsc.h@@ -16,11 +16,15 @@ #define __SC "sc " #define __INS "ins " #define __EXT "ext " +#define __ADDU "addu " +#define __SUBU "subu " #elif _MIPS_SZLONG == 64 #define __LL "lld " #define __SC "scd " #define __INS "dins " #define __EXT "dext " +#define __ADDU "daddu " +#define __SUBU "dsubu "
Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)? Maciej