Thread (6 messages) 6 messages, 4 authors, 2021-07-27

Re: [PATCH] asm-generic: avoid sparse {get,put}_unaligned warning

From: Arnd Bergmann <arnd@arndb.de>
Date: 2021-07-26 12:57:53
Also in: batman, lkml

On Sat, Jul 24, 2021 at 7:01 PM Al Viro [off-list ref] wrote:
On Sat, Jul 24, 2021 at 06:24:29PM +0200, Sven Eckelmann wrote:
quoted
The special attribute force must be used in such statements when the cast
is known to be safe to avoid these warnings.
I can see why this would warn, but I'm having trouble reproducing the
warning on linux-next.
        How about container_of(ptr, typeof(*__pptr), x) instead of a cast?
Would be easier to follow...
If both work equally well, I'd prefer Sven's patch since that only
expands 'type'
once, while container_of() expands it three more times. This may not make
much of a difference, but I've seen a number of cases where nested macros
can explode the preprocessed code size enough to slow down kernel compilation
over all, and it's quite possible to have get_unaligned()/put_unaligned in
the middle of that, with a complex expression passed into that.

      Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help